Finalization milestone of the feed browser redesign. Work so far is from 99puxwol5 (acceptance pass), which is not finished: the run was stopped at Cesar's request.
What changed:
src/styles/legacy.css is deleted and no longer imported. Its last rules in use moved: .center to layout.css, the error box to .signin-error (signin.css) and .composer-error (composer.css), and font: inherit for form controls to the globals reset layer. The global button margin rule and button:disabled { opacity:.5 } are gone.
The weight of the Discover row sub-labels is now set in buttons.css (it used to be inherited from the legacy button rule).
The four "Try again" buttons (feed error, load-more error, desktop and mobile) had no class of their own and relied on legacy.css. They now use the outline sweep button.
The button tests now check that legacy.css is gone, that layout does not import it, and that no stylesheet fades disabled buttons.
Visible effect of the deletion: computed styles of every element were compared before and after on /, /dev/feed and /dev/buttons at 1440, 1024, 820 and 390px, dark and light, in 44 states. The only visible changes fix bugs the legacy margin caused. The mobile dock is 64px tall again (it was 80px, with the like, comment and More icons 16px off center). The sheet backdrop now covers the full screen (it was shifted down 16px).
Verified: tsc, eslint, vitest (262 passed) and next build pass.
CRM task: 99puxwol5. The acceptance results are in the CRM comment on that task.
Finalization milestone of the feed browser redesign. Work so far is from 99puxwol5 (acceptance pass), which is not finished: the run was stopped at Cesar's request.
What changed:
- `src/styles/legacy.css` is deleted and no longer imported. Its last rules in use moved: `.center` to layout.css, the error box to `.signin-error` (signin.css) and `.composer-error` (composer.css), and `font: inherit` for form controls to the globals reset layer. The global `button` margin rule and `button:disabled { opacity:.5 }` are gone.
- The weight of the Discover row sub-labels is now set in buttons.css (it used to be inherited from the legacy button rule).
- The four "Try again" buttons (feed error, load-more error, desktop and mobile) had no class of their own and relied on legacy.css. They now use the outline sweep button.
- The button tests now check that legacy.css is gone, that layout does not import it, and that no stylesheet fades disabled buttons.
Visible effect of the deletion: computed styles of every element were compared before and after on /, /dev/feed and /dev/buttons at 1440, 1024, 820 and 390px, dark and light, in 44 states. The only visible changes fix bugs the legacy margin caused. The mobile dock is 64px tall again (it was 80px, with the like, comment and More icons 16px off center). The sheet backdrop now covers the full screen (it was shifted down 16px).
Verified: tsc, eslint, vitest (262 passed) and next build pass.
CRM task: 99puxwol5. The acceptance results are in the CRM comment on that task.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Finalization milestone of the feed browser redesign. Work so far is from 99puxwol5 (acceptance pass), which is not finished: the run was stopped at Cesar's request.
What changed:
src/styles/legacy.cssis deleted and no longer imported. Its last rules in use moved:.centerto layout.css, the error box to.signin-error(signin.css) and.composer-error(composer.css), andfont: inheritfor form controls to the globals reset layer. The globalbuttonmargin rule andbutton:disabled { opacity:.5 }are gone.Visible effect of the deletion: computed styles of every element were compared before and after on /, /dev/feed and /dev/buttons at 1440, 1024, 820 and 390px, dark and light, in 44 states. The only visible changes fix bugs the legacy margin caused. The mobile dock is 64px tall again (it was 80px, with the like, comment and More icons 16px off center). The sheet backdrop now covers the full screen (it was shifted down 16px).
Verified: tsc, eslint, vitest (262 passed) and next build pass.
CRM task: 99puxwol5. The acceptance results are in the CRM comment on that task.